Skip to content

ed: shell command io #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

ed: shell command io #824

merged 1 commit into from
Nov 19, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 19, 2024

  • Reject filenames starting with '!' for f command (other versions reject this)
  • Implement "r !cmd" in edEdit() to read output of a shell command into the editor buffer
  • Implement "w !cmd" in edWrite() to pass data from editor buffer to a shell command
  • test1: 2r !ifconfig ---> output from ifconfig is added after line 2
  • test2: 1,20w !cat -n ---> lines 1-20 from buffer are piped to "cat -n"

@mknos
ed: shell command io
2878e72 
* Reject filenames starting with '!' for f command (other versions reject this)
* Implement "r !cmd" in edEdit() to read output of a shell command into the editor buffer
* Implement "w !cmd" in edWrite() to pass data from editor buffer to a shell command
* test1: 2r !ifconfig ---> output from ifconfig is added after line 2
* test2: 1,20w !cat -n ---> lines 1-20 from buffer are piped to "cat -n"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 19, 2024
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 07:11 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11907987140

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11903396689: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 3f84fd3 into briandfoy:master Nov 19, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Nov 19, 2024
@briandfoy
Copy link
Owner

briandfoy commented Nov 19, 2024 •
edited
Loading

changes: implement reading output from a command (r !cmd) and writing to a command (w !cmd), and reject filenames that start with ! for f command.

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy