Skip to content

grep: make space after -e or -f optional #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2024
Merged

grep: make space after -e or -f optional #816

merged 1 commit into from
Nov 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 17, 2024

  • BSD and GNU versions do not require a space between -e/-f and the option argument
  • This version did not raise an error, but option arguments without a space resulted in incorrect behaviour
  • Remove -e and -f from getopts() option string because they are handled earlier
  • test1: perl grep -e0 -e 1 ar ---> patterns 0 and 1 in file ar
  • test2: grep -fwordlist.txt.old -f pat1 xargs ---> patterns from file wordlist.txt.old and pat1, searching against file xargs

@mknos
grep: make space after -e or -f optional
b8a795c 
* BSD and GNU versions do not require a space between -e/-f and the option argument
* This version did not raise an error, but option arguments without a space resulted in incorrect behaviour
* Remove -e and -f from getopts() option string because they are handled earlier
* test1: perl grep -e0 -e 1 ar ---> patterns 0 and 1 in file ar
* test2: grep -fwordlist.txt.old -f pat1 xargs ---> patterns from file wordlist.txt.old and pat1, searching against file xargs
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@github-actions github-actions bot added the Type: enhancement improve a feature that already exists label Nov 17, 2024
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@github-actions github-actions bot added Priority: low get to this whenever Program: grep The grep program labels Nov 17, 2024
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 11:30 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11878466242

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11877408150: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy added Type: compatability make it work like GNU or BSD and removed Type: enhancement improve a feature that already exists labels Nov 17, 2024
@briandfoy briandfoy self-assigned this Nov 17, 2024
@briandfoy briandfoy merged commit 500e24e into briandfoy:master Nov 17, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: make space after -e or -f optional

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 17, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy