Skip to content

cal: deal with warnings #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

cal: deal with warnings #805

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • When temporarily enabling warnings.pm I noticed two patterns which generated a warning
  • In get_year(), regex check was done too late after the variable has been treated as a number
  • In print_year()/print_year_jd() the month lists being combined might have a less elements; explicitly treat those as empty string

@mknos
cal: deal with warnings
e4467df 
* When temporarily enabling warnings.pm I noticed two patterns which generated a warning
* In get_year(), regex check was done too late after the variable has been treated as a number
* In print_year()/print_year_jd() the month lists being combined might have a less elements; explicitly treat those as empty string
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cal The cal program labels Nov 12, 2024
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:45 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11792828480

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 77ce1d4 into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: silence some warnings with better checks

@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cal The cal program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy