Skip to content

rmdir: better error reporting #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

rmdir: better error reporting #803

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • The old error message is not specific enough to be helpful
  • Allow rmdir() to fail instead of performing file tests first
  • $! will specifically say whether a file argument does not exist, or is not a directory

@mknos
rmdir: better error reporting
0165709 
* The old error message is not specific enough to be helpful
* Allow rmdir() to fail instead of performing file tests first
* $! will specifically say whether a file argument does not exist, or is not a directory
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: rmdir The rmdir program labels Nov 12, 2024
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 07:27 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11792598182

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy briandfoy merged commit 8895e4b into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: test that an argument is a directory before trying to remove it (better error message)

@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 13, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: rmdir The rmdir program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy