Skip to content

ed: retire non-standard debug flag -d #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

ed: retire non-standard debug flag -d #793

merged 1 commit into from
Nov 11, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 11, 2024

  • This version of ed is different to the C versions because it's trivial to run it under the perl debugger, e.g. setting a breakpoint in edParse() or input()
  • The debug info produced by running "ed -d" is limited, and other versions of ed don't provide an equivalent option
  • Sync usage string + SYNOPSIS
  • Add symbolic exit codes as done in other scripts

@mknos
ed: retire non-standard debug flag -d
f87e358 
* This version of ed is different to the C versions in that it's trivial to run it under the perl debugger
* The debug info produced by running "ed -d" is limited, and other versions of ed don't provide an equivalent option
* Sync usage string + SYNOPSIS
* Add symbolic exit codes as done in other scripts
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 11, 2024
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 11, 2024 01:06 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11770216626

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11756374327: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

briandfoy
briandfoy approved these changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly agree with this change in principle, but if the -d really doesn't help because it has low instrumentation, yeah, rip it out. If there was good instrumentation, I'd probably go the other way.

@briandfoy briandfoy merged commit 2c9634f into briandfoy:master Nov 11, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: remove -d (debugging) switch since the debugging output isn't that helpful

@briandfoy briandfoy self-assigned this Nov 11, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 11, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy