Skip to content

pr: more compatible -h option #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2024
Merged

pr: more compatible -h option #791

merged 1 commit into from
Nov 9, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 8, 2024

  • Follow semantics of OpenBSD version
  • Suppress file header with: pr -h ''
  • Don't ignore "pr -h 0" because "0" is a valid header
  • Also remove unused param $col from create_col(), which is never called with any params

@mknos
pr: more compatible -h option
9b4b648 
* Follow semantics of OpenBSD version
* Suppress file header with: pr -h ''
* Don't ignore "pr -h 0" because "0" is a valid header
* Also remove unused param $col from create_col(), which is never called with any params
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: pr The pr program labels Nov 8, 2024
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 13:13 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11742772865

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11738096177: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 9, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Nov 9, 2024
@briandfoy briandfoy merged commit 23b7daa into briandfoy:master Nov 9, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: allow 0 to be a valid header (check for definedness, not truth)

@briandfoy briandfoy added Status: accepted The fix is accepted Type: compatability make it work like GNU or BSD and removed Priority: low get to this whenever labels Nov 11, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: pr The pr program Status: released there is a new release with this fix Type: bug an existing feature does not work Type: compatability make it work like GNU or BSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy