Skip to content

ed: make wq shortcut work again #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

ed: make wq shortcut work again #790

merged 1 commit into from
Nov 8, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 8, 2024

  • Previously typing wq was supported, but recent changes in edParse() broke it
  • Command suffix processing goes before check for a space, then optional filename argument
  • This time document wq in pod

@mknos
ed: make wq shortcut work again
a4d8a26 
* Previously typing wq was supported, but recent changes in edParse() broke it
* Command suffix processing goes before check for a space, then optional filename argument
* This time document wq in pod
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 8, 2024
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 8, 2024 07:30 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11737938731

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11732882413: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 524062c into briandfoy:master Nov 8, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: make wq shortcut work again after previous fix changed it

@briandfoy briandfoy self-assigned this Nov 8, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Nov 8, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy