Skip to content

kill: list valid signals for bad -NUMBER #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

kill: list valid signals for bad -NUMBER #781

merged 1 commit into from
Nov 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 4, 2024

  • When entering an invalid named signal argument, e.g. -NOTVALID, kill shows an error with a list of valid signals
  • Do the same for invalid numeric signal arguments, e.g. -100000

@mknos
kill: list valid signals for bad -NUMBER
374fc37 
* When entering an invalid named signal argument, e.g. -NOTVALID, kill shows an error with a list of valid signals 
* Do the same for invalid numeric signal arguments, e.g. -100000
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: kill The kill program labels Nov 4, 2024
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 11:41 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11663484761

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11655461453: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11663484765

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11655461453: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 7540826 into briandfoy:master Nov 5, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Nov 5, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 5, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 5, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Nov 5, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: kill The kill program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy