Skip to content

ed: support ?re? address mode #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

ed: support ?re? address mode #774

merged 1 commit into from
Oct 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 30, 2024 •
edited
Loading

  • ?re? is a valid prefix which searches backward
  • Tested against GNU and OpenBSD versions
  • test1: ?perl?n ---> search for previous instance of "perl" then run command n
  • test2: ??l ---> search for previous instance of saved pattern "perl" then run command l
  • test3: ?\??p ---> search backwards for literal "?" then run command p
  • test4: ?\/\/? ---> search backward for literal "//" then show result

@mknos
ed: support ?re? address mode
f811f4c 
* ?re? is a valid prefix which searches backward
* Tested against GNU and OpenBSD versions
* test1: ?perl?n ---> search for previous instance of "perl" then run command n
* test2: ??l ---> search for previous instance of saved pattern "perl" then run command l
* test3: ?\??p ---> search backwards for literal "?" then run command p
* test4: ?\/\/? ---> search backward for literal "//" then show result
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 30, 2024
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 30, 2024 00:22 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11584620150

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11575383088: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 3a50a5f into briandfoy:master Oct 30, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: support ?re? address mode

@briandfoy briandfoy self-assigned this Oct 30, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 30, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy