Skip to content

grep: bad filehandle passed to close() #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

grep: bad filehandle passed to close() #746

merged 1 commit into from
Sep 27, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 27, 2024

  • When temporarily enabling warnings+diagnostics in grep I observed a warning related to FILE being used only once
  • The close(FILE) statement was incorrect because the current input file is actually $fh
  • The correct place to close the file was after the LINE-loop
  • Technically $fh was being closed implicitly after each FILE-loop, but keep the pattern of explicitly closing it
  • Style: where possible, refer to the LINE-loop when jumping from within the LINE-loop
  • Also convert PATFILE into a regular "my" variable, so there are no more bareword files

@mknos
grep: bad filehandle passed to close()
d193272 
* When temporarily enabling warnings+diagnostics in grep I observed a warning related to FILE being used only once
* The close(FILE) statement was incorrect because the current input file is actually $fh
* The correct place to close the file was after the LINE-loop
* Technically $fh was being closed implicitly after each FILE-loop, but keep the pattern of explicitly closing it
* Style: where possible, refer to the LINE-loop when jumping from within the LINE-loop
* Also convert PATFILE into a regular "my" variable, so there are no more bareword files
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Sep 27, 2024
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 27, 2024 02:02 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11063224228

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11045529272: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 8bdcd74 into briandfoy:master Sep 27, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Sep 27, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Sep 27, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work Status: released there is a new release with this fix and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever Status: accepted The fix is accepted labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy