grep: wrong exit code for grep -s

[mknos]

• This version of grep skips binary files by default; this behaviour is inconsistent with GNU version but the difference could be addressed later
• If the file argument exists but cannot be opened, grep was skipping the file with a strange "binary file" message
• I found this when testing "grep -s", which is expected to exit with 2 if a file couldn't be opened
• I triggered open() error by removing file permissions on my Linux system

%chmod 0 a.c
%perl grep -T include a.c
grep: skipping binary file "a.c"

• Correct the binary file condition; skip the file argument if file is binary (filetest -B) and we're not running grep -a
• Correct the logic for exit code; $Errors should increment regardless of -s because exit code is determined from it
• Bump version
• With patch applied, grep (without -s) correctly prints the error from open() (Permission Denied for my test), and exits with code 2
• Regression test: "perl grep -s pat1 bad.file.name" --> exit 2, silent

[coveralls]

Pull Request Test Coverage Report for Build 10980919074

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.7%) to 73.069%

---

Totals
Change from base Build 10973938881:	-0.7%
Covered Lines:	350
Relevant Lines:	479

---

💛 - Coveralls

[briandfoy]

nice catch

[briandfoy]

changes: -s now exits with correct value if It cannot read the file; -a works correctly if the perl thinks the file is binary and you selected -a