Skip to content

grep: small cleanup #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2024
Merged

grep: small cleanup #740

merged 1 commit into from
Sep 21, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 21, 2024

  • Declare globals directly with "my" instead of "use vars"
  • Declare $term variable only in the context of Term::Cap eval failure

@mknos
grep: small cleanup
91c00d2 
* Declare globals directly with "my" instead
* Declare $term variable only in the context of Term::Cap eval failure
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Sep 21, 2024
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 21, 2024 07:19 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10970703358

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10964008326: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Sep 21, 2024
@briandfoy briandfoy merged commit 15f4641 into briandfoy:master Sep 21, 2024
22 of 23 checks passed
@briandfoy briandfoy added Type: modernization updating programs to current practices and removed Type: enhancement improve a feature that already exists labels Sep 21, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy