Skip to content

col: dead buffering code #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

col: dead buffering code #737

merged 1 commit into from
Sep 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 17, 2024

  • Partial file buffering code was removed in commit 5da850a
  • Argument to option -l was being validated as a number, but $opt_l was effectively unused
  • Remove validation code but it's not harmful keeping -l option as a stub since it appears in other versions (e.g. GNU and FreeBSD)
  • Update description of -l in POD

@mknos
col: dead buffering code
6fe1afa 
* Partial file buffering code was removed in commit 5da850a
* Argument to option -l was being validated as a number, but $opt_l was effectively unused
* Remove validation code but it's not harmful keeping -l option as a stub since it appears in other versions (e.g. GNU and FreeBSD)
* Update description of -l in POD
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: col The col program labels Sep 17, 2024
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 17, 2024 12:41 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10903238212

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10866274056: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10903238204

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10866274056: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 724ad81 into briandfoy:master Sep 17, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -l is now a no-op, but preserved for legacy operation.

@briandfoy briandfoy self-assigned this Sep 17, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Sep 17, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: col The col program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy