Skip to content

diff: catfile > join #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

diff: catfile > join #726

merged 1 commit into from
Aug 23, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 23, 2024

  • Similar to commit 2531425 for bin/grep, join a filename to a directory with catfile(), which would make the correct choice of separator for windows
  • To test this I make a directory, copy a file in there and compare it with the one in working directory
%mkdir dir0
%cp a.c dir0
%perl diff a.c dir0
%perl diff dir0 a.c

@mknos
diff: catfile > join
f633286 
* Similar to commit 2531425 for bin/grep, join a filename to a directory with catfile(), which would make the correct choice of separator for windows
* To test this I make a directory, copy a file in there and compare it with the one in working directory

%mkdir dir0
%cp a.c dir0
%perl diff a.c dir0
%perl diff dir0 a.c
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: diff The diff program labels Aug 23, 2024
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 23, 2024 03:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10519419429

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.805%
Totals Coverage Status
Change from base Build 10458728518: 0.0%
Covered Lines: 355
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy merged commit 0f7f740 into briandfoy:master Aug 23, 2024
23 checks passed
@briandfoy briandfoy self-assigned this Aug 23, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 23, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Aug 23, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: diff The diff program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy