Skip to content

random: raise error for bad option #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2024
Merged

random: raise error for bad option #720

merged 1 commit into from
Aug 14, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 14, 2024

  • Comparing the NetBSD version of the random-lines game, unknown options should result in usage string being printed
  • Usage was already printed for too-many-arguments case
  • Create a regular usage() function as done in other scripts
%ifconfig | perl random -r 6 # test1: -r
        RX packets 0  bytes 0 (0.0 B)

        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        RX packets 2057  bytes 452554 (441.9 KiB)
%perl random -e 100 # test2: -e
%echo $?
35
%perl random -x # test3: bad option
Unknown option: x
usage: random [-er] [denominator]
%perl random 123 456 # test4: too many args
usage: random [-er] [denominator]

@mknos
random: raise error for bad option
56e300c 
* Comparing the NetBSD version of the random-lines game, unknown options should result in usage string being printed
* Usage was already printed for too-many-arguments case
* Create a regular usage() function as done in other scripts
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: random The random program labels Aug 14, 2024
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 09:16 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10384822645

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10383699416: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Aug 14, 2024
@briandfoy
Copy link
Owner

changes: die for bad options

@briandfoy briandfoy merged commit 535e704 into briandfoy:master Aug 14, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Aug 14, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Aug 14, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: random The random program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy