Skip to content

id: gid 0 is valid #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

id: gid 0 is valid #715

merged 1 commit into from
Aug 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 12, 2024

  • Previously commit 92678da was added to allow resolving "root" to uid 0
  • When testing -g option a similar issue was discovered (gid of 0 was being treated as a failure of getpwnam)
  • This was discovered while testing against id on my Linux system
%grep '^root' /etc/group 
root:x:0:
%/usr/bin/id -g root
0
%perl id -g root # before patch
1000

@mknos
id: gid 0 is valid
85b0737 
* Previously commit 92678da was added to allow resolving "root" to uid 0
* When testing -g option a similar issue was discovered (gid of 0 was being treated as a failure of getpwnam)
* This was discovered while testing against id on my Linux system

%grep '^root' /etc/group 
root:x:0:
%/usr/bin/id -g root
0
%perl id -g root # before patch
1000
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: id The id program labels Aug 12, 2024
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 08:07 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10348154532

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10316135952: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 4ef9c6d into briandfoy:master Aug 12, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: allow gid to be 0

@briandfoy briandfoy self-assigned this Aug 12, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: id The id program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy