Skip to content

cmp: sysread failure guard #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

cmp: sysread failure guard #711

merged 1 commit into from
Aug 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 12, 2024

  • Input loop terminates if sysread on file1 fails
  • If sysread failed on file2, $read_in2 would be undef, then $checklength would be undef
  • It is not correct to compare the two input buffers in this case; $buffer2 possibly wouldn't have been modified since the previous loop iteration
  • Skip the buffer comparison if $checklength is zero (treat sysread failure in the same way because there are no bytes to compare)
  • In this case it would be correct for cmp to report "EOF on file2" because the read length for file1 is greater

@mknos
cmp: sysread failure guard
2034b37 
* Input loop terminates if sysread on file1 fails
* If sysread failed on file2, $read_in2 would be undef, then $checklength would be undef
* It is not correct to compare the two input buffers in this case; $buffer2 possibly wouldn't have been modified since the previous loop iteration
* Skip the buffer comparison if $checklength is zero (treat sysread failure in the same way because there are no bytes to compare)
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cmp The cop program labels Aug 12, 2024
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:44 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 02:45 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10345082371

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10316135952: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 23939b7 into briandfoy:master Aug 12, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: stop if we can't read from the first file

@briandfoy briandfoy self-assigned this Aug 12, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cmp The cop program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy