Skip to content

bc: remove signal handling #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

bc: remove signal handling #705

merged 1 commit into from
Aug 7, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 7, 2024

  • Standard bc does not require any signal handling [1]
  • Different versions of bc treat SIGINT differently
  • The previous code resulted in bc exiting on ^C on my Linux system, so there's effectively no difference with this patch
  1. https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/utilities/bc.html

@mknos
bc: remove signal handling
3073139 
* Standard bc does not require any signal handling [1]
* Different versions of bc treat SIGINT differently
* The previous code resulted in bc exiting on ^C on my Linux system, so there's effectively no difference with this patch

1. https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/utilities/bc.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: bc The bc program labels Aug 7, 2024
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 7, 2024 09:00 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10281308384

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.375%
Totals Coverage Status
Change from base Build 10269273695: -0.7%
Covered Lines: 350
Relevant Lines: 477
💛 - Coveralls

briandfoy
briandfoy approved these changes Aug 7, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that maybe we could catch SIGINT to exit cleanly, but, then, there's nothing we have to clean up and the result would be the same.

@briandfoy briandfoy merged commit e887064 into briandfoy:master Aug 7, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 7, 2024
@briandfoy briandfoy self-assigned this Aug 7, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: bc The bc program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy