factor: increase range and speed up code #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix CPAN RT #98905 / Issue #404 and make factor to handle as large integers possible without using bignum (or similar). - Use a different algorithm (wheel factorisation of order 6), which is much faster for larger integers.
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Aug 5, 2024
briandfoy
added
Status: accepted
|
Congratulations on your first PR :) |
|
changes: completely replace factor with a program using the wheel algorithm to make it speedy (#404), from Peter John Acklam |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CPAN RT #98905 / Issue RT #98905: factor and primes are limited to 2^32 #404 and make factor to handle as large integers possible without using bignum (or similar).
Use a different algorithm (wheel factorisation of order 6), which is much faster for larger integers.