patch: delete dead -x option #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Aug 5, 2024
mknos
commented
- The -x (aka --debug) option exists in the GNU version of patch, but the perl version never did anything with -x
- Mentioning -x in the pod manual makes the useful information more difficult to find
- This option is not covered by the standard so removing it is not a compatibility issue [1]
- Debugging the perl version can be as simple as setting a breakpoint in Patch::apply() or Patch::Ed::apply()
- https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html
* The -x (aka --debug) option exists in the GNU version of patch, but the perl version never did anything with -x * Mentioning -x in the pod manual makes the useful information more difficult to find * This option is not covered by the standard so removing it is not a compatibility issue [1] * Debugging the perl version can be as simple as setting a breakpoint in Patch::apply() or Patch::Ed::apply() 1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
github-actions
bot
added
the
Type: enhancement
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
approved these changes
Aug 5, 2024
|
changes: remove -x option (debugging) that wasn't doing anything |
briandfoy
added
Status: accepted
briandfoy
added
Status: released
briandfoy
added
Type: compatability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.