Skip to content

fmt: validate width #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

fmt: validate width #695

merged 1 commit into from
Aug 2, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 2, 2024

  • I observed a suspicious warning when providing negative number as input...
%perl fmt -w-1000000 a.c > /dev/null
Negative repeat count does nothing at fmt line 34.
  • Value for -w must be an int; follow OpenBSD fmt and raise error for 0 and negative
  • test1: "perl fmt -w 1.1 a.c" --> already covered by Getopt::Long
  • test2: "perl fmt -w'' a.c" --> same as test1
  • test3: "perl fmt -w0 a.c" --> new validation
  • test4: "perl fmt -w-100 a.c" --> same as test3

@mknos
fmt: validate width
5144ed7 
* I observed a suspicious warning when providing negative number as input...
%perl fmt -w-1000000 a.c > /dev/null
Negative repeat count does nothing at fmt line 34.

* Value for -w must be an int; follow OpenBSD fmt and raise error for 0 and negative
* test1: "perl fmt -w 1.1  a.c" --> already covered by Getopt::Long
* test2: "perl fmt -w''  a.c" --> same as test1
* test3: "perl fmt -w0  a.c" --> new validation
* test4: "perl fmt -w-100  a.c" --> same as test3
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: fmt The fat program labels Aug 2, 2024
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:57 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 08:58 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10212871433

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Files with Coverage Reduction New Missed Lines %
bin/units 3 71.21%
Totals Coverage Status
Change from base Build 10212435055: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit de06294 into briandfoy:master Aug 2, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: max width must be greater than zero

@briandfoy briandfoy removed the Priority: low get to this whenever label Aug 2, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Aug 2, 2024
@briandfoy briandfoy self-assigned this Aug 2, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: fmt The fat program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy