Skip to content

kill: sanity check siglist #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

kill: sanity check siglist #691

merged 1 commit into from
Jul 31, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 31, 2024

  • Move some top-level code into a function
  • Fail early if the result of split() is an empty list; this shouldn't happen but previously the list size was not checked

@mknos
kill: sanity check siglist
2056716 
* Move some top-level code into a function
* Fail early if the result of split() is an empty list; this shouldn't happen but previously the list size was not checked
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: kill The kill program labels Jul 31, 2024
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 31, 2024 07:03 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10175625364

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Files with Coverage Reduction New Missed Lines %
bin/units 3 71.21%
Totals Coverage Status
Change from base Build 10173605741: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jul 31, 2024
@briandfoy briandfoy merged commit 14b7b7a into briandfoy:master Jul 31, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jul 31, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: kill The kill program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy