Skip to content

sort: reject directory arguments #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

sort: reject directory arguments #688

merged 1 commit into from
Jul 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 30, 2024

  • If any file argument is a directory, sort should print an error and exit
  • I found this when testing against GNU and OpenBSD versions

@mknos
sort: reject directory arguments
67dd621 
* If any file argument is a directory, sort should print an error and exit
* I found this when testing against GNU and OpenBSD versions
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@github-actions github-actions bot added the Type: enhancement improve a feature that already exists label Jul 30, 2024
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@github-actions github-actions bot added Priority: low get to this whenever Program: sort The sort program labels Jul 30, 2024
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 30, 2024 11:21 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10161406007

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.016%
Totals Coverage Status
Change from base Build 10142635493: 0.0%
Covered Lines: 382
Relevant Lines: 496
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jul 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10161406007

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.016%
Totals Coverage Status
Change from base Build 10142635493: 0.0%
Covered Lines: 382
Relevant Lines: 496
💛 - Coveralls

@briandfoy briandfoy merged commit 2b457e2 into briandfoy:master Jul 30, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: die if an argument is a directory

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 5, 2024
@briandfoy briandfoy self-assigned this Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: sort The sort program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy