Skip to content

split: out-of-order check #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2024
Merged

split: out-of-order check #675

merged 1 commit into from
Jul 21, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 21, 2024

  • The check for the special argument '-' should take place before stat
  • The old code was wrong because "split -" produced 2 different results depending on whether I had a directory called "-"
  • test1: "perl split -" == stdin
  • test2: "perl split ./-" == file called "-"
  • test3: "perl split -- -" == same as test1

@mknos
split: out-of-order check
a485a4c 
* Check for special argument '-' should take place before stat
* The old code was wrong because "split -" had 2 different results depending on whether I had a directory called "-"
* test1: "perl split -"  == stdin
* test2: "perl split ./-" == file called "-"
* test3: "perl split -- -" == same as test1
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: split The split program labels Jul 21, 2024
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 21, 2024 05:51 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10026036118

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10022406115: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jul 21, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Jul 21, 2024
@briandfoy briandfoy added the Type: bug an existing feature does not work label Jul 21, 2024
@briandfoy briandfoy merged commit 32b8271 into briandfoy:master Jul 21, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: allow for a directory named - without confusing it for stdin.

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: split The split program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy