Skip to content

ls: -1 for non-tty #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2024
Merged

ls: -1 for non-tty #660

merged 1 commit into from
Jun 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 26, 2024

  • The manual explains that if output is not a tty, ls will infer the -1 flag (i.e. print one entry per line)
  • The old filemode check code did not work on my Linux system but this patch does
  • I tested this with a pipe into cat, and with a redirect into a file

@mknos
ls: -1 for non-tty
a87f2ca 
* The manual explains that if output is not a tty, ls will infer the -1 flag (i.e. print one entry per line)
* The old filemode check code did not work on my Linux system but this patch does
* I tested this with a pipe into cat, and with a redirect into a file
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ls The ls program labels Jun 26, 2024
@briandfoy briandfoy self-assigned this Jun 26, 2024
@briandfoy briandfoy merged commit b418842 into briandfoy:master Jun 26, 2024
@briandfoy
Copy link
Owner

changes: infer -1 switch automatically if the output filehandle is not a tty

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 26, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ls The ls program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy