Skip to content

cp: support '--' terminator #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

cp: support '--' terminator #642

merged 1 commit into from
Jun 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 5, 2024

  • '--' option terminator is ignored when executing an external command
  • When debugging this I discovered the command list passed to system() strips off the '--' (technically Getopt::Long does)
  • Explicit terminator can be added between options and filenames
%perl cp -- -a ..   # before patch, on linux
cp: missing destination file operand after '..'
Try 'cp --help' for more information.

@mknos
cp: support '--' terminator
202fcaa 
* '--' option terminator is ignored when executing an external command
* When debugging this I discovered the command list passed to system() strips off the '--' (technically Getopt::Long does)
* Explicit terminator can be added between options and filenames

%perl cp -- -a ..   # before patch
cp: missing destination file operand after '..'
Try 'cp --help' for more information.
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cp The cp command labels Jun 5, 2024
@briandfoy briandfoy self-assigned this Jun 5, 2024
@briandfoy briandfoy merged commit 036b22f into briandfoy:master Jun 5, 2024
@briandfoy
Copy link
Owner

changes: stop option parsing after --

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 5, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cp The cp command Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy