Skip to content

grep -F versus stdin #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

grep -F versus stdin #641

merged 1 commit into from
Jun 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 5, 2024

  • ARGV list was supposed to have the value '-' added if it was empty
  • I noticed that grep would simply exit for the following test: echo hello1 | perl grep -F 1
  • In this usage the argument "1" is shifted off ARGV list and the code to reset ARGV was happening too late (problem caused by recent grep -F code addition)

@mknos
grep -F versus stdin
dd97f04 
* ARGV list was supposed to have the value '-' added if it was empty
* I noticed that grep would simply exit for the following test: echo hello1 | perl grep -F 1
* In this usage the argument "1" is shifted off ARGV list and the code to reset ARGV was happening too late (problem caused by recent grep -F code addition)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Jun 5, 2024
@briandfoy briandfoy merged commit caf4f5f into briandfoy:master Jun 5, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jul 11, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
@briandfoy briandfoy self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy