Skip to content

grep: fix -Fh #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

grep: fix -Fh #635

merged 1 commit into from
Jun 4, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 4, 2024

  • When combining grep -F and -h flags, the filenames were not listed for matches (correct), but they still were not listed when unsetting -h (incorrect)
  • test1: "perl grep -F '/' awk ar" --> output should show "$filename:" prefix
  • Init of global variable $Mult was missed due to early return in parse_args()
  • I also tested that -Fl works as expected
  • While here, remove the need for variable $optstring by passing options directly to getopts()

@mknos
grep: fix -Fh
441fdec 
* When combining grep -F and -h flags, the filenames were not listed for matches, but they still were not listed when unsetting -h
* test1: "perl grep -F '/' awk ar" --> output should show "$filename:" prefix
* Init of global variable $Mult was missed due to early return in parse_args()
* I also tested that -Fl works as expected
* While here, remove the need for variable $optstring by passing options directly to getopts()
* Bump version
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Jun 4, 2024
@briandfoy
Copy link
Owner

changes: show filenames even without -h set

@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Jun 4, 2024
@briandfoy briandfoy merged commit 4a87acf into briandfoy:master Jun 4, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 4, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
@briandfoy briandfoy self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy