du: remove unix path assumption #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
May 29, 2024
mknos
commented
- du had a documented bug where '/' was the path separator
- As done in other scripts, make use of catfile() when joining a directory name to a filename
- This works the same on my Linux system, but in theory it will work better on windows
- catfile() can handle directory names with a redundant separator at the end, so a conditional expression is not needed
- Remove global variable $dirsep
* du had a documented bug where '/' was the path separator * As done in other scripts, make use of catfile() when joining a directory name to a filename * This works the same on my Linux system, but in theory it will work better on windows * Remove global variable $dirsep
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
May 29, 2024
briandfoy
added
Status: accepted
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.