Skip to content

bc: mod zero #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

bc: mod zero #617

merged 1 commit into from
May 23, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 23, 2024 •
edited
Loading

  • When adding previous commit to avoid divide by zero, mod 0 was missed
  • Patch tested under default mode and bignum mode (bc -b)
a=123
b=0
a%b

@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: bc The bc program labels May 23, 2024
@briandfoy
Copy link
Owner

changes: fix regression in modulus 0 operation

@briandfoy briandfoy merged commit 76d4c1f into briandfoy:master May 23, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels May 23, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
@briandfoy briandfoy self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: bc The bc program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy