Skip to content

grep: pattern of 0 #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

grep: pattern of 0 #607

merged 1 commit into from
May 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 17, 2024

  • The following correct usage was not accepted: "perl grep 0 file"
  • Within parse_args(), $opt{e} was initialised to 0 but that is confusing because 0 could be a pattern; instead set it to empty string
  • First check if $opt{e} and use it if not empty
  • Expect pattern to be the next ARGV element
  • Raise error via usage() only if there were no remaining ARGV elements (previously usage() was called if it was 0, i.e. false)

@mknos
grep: pattern of 0
8f3ebe6 
* The following correct usage was not accepted: "perl grep 0 file"
* Within parse_args(), $opt{e} was initialised to 0 but that is confusing because 0 could be a pattern; instead set it to empty string
* First check if $opt{e} and use it if not empty
* Expect pattern to be the next ARGV element
* Raise error via usage() only if there were no remaining ARGV elements (previously usage() was called if it was 0, i.e. false)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels May 17, 2024
@briandfoy
Copy link
Owner

changes: the default for -e is now the empty string, and the value 0 is taken to be a valid pattern

@briandfoy briandfoy merged commit f00a886 into briandfoy:master May 22, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels May 22, 2024
@briandfoy briandfoy self-assigned this May 22, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy