Skip to content

ls: conditional get_columns() #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

ls: conditional get_columns() #606

merged 1 commit into from
May 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 16, 2024

  • get_columns() has the side effect of running external commands via unix() function
  • Not all modes of ls need the value of $WinCols, e.g. "ls -1" and "ls -l"
  • Init $WinCols the 1st time it is used within List()
  • "defined" guard is there because List() can be called repeatedly, e.g. "ls dir1 dir2"

@mknos
ls: conditional get_columns()
1f6fded 
* get_columns() has the side effect of running external commands via unix() function
* Not all modes of ls need the value of $WinCols, e.g. "ls -1" and "ls -l"
* Init $WinCols the 1st time it is used within List()
* "defined" guard is there because List() can be called repeatedly, e.g. "ls dir1 dir2"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ls The ls program labels May 16, 2024
@briandfoy briandfoy merged commit e948dd4 into briandfoy:master May 22, 2024
@briandfoy briandfoy self-assigned this May 22, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels May 22, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ls The ls program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy