Skip to content

bc: remove alias sub #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

bc: remove alias sub #600

merged 1 commit into from
May 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 11, 2024

  • YYERROR() was an alias for yy_err_recover()
  • YYERROR() was only called once, so call yy_err_recover() directly
  • When testing, I temporarily forced $return=2 instead of working out how to trigger it

@mknos
bc: remove alias sub
13a5ae1 
* YYERROR() was an alias for yy_err_recover()
* YYERROR() was only called once, so call yy_err_recover() directly
* When testing, I temporarily forced $return=2 instead of working out how to trigger it
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: bc The bc program labels May 11, 2024
briandfoy
briandfoy approved these changes May 22, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change and I hope we get more of these sorts of trimmings in bc

@briandfoy briandfoy merged commit 93bb386 into briandfoy:master May 22, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels May 22, 2024
@briandfoy briandfoy self-assigned this May 22, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: bc The bc program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy