nl: support one file argument #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Mar 2, 2024
mknos
commented
- Standard nl is not required to support multiple input files [1]
- Follow BSD versions of nl and support only one input file, which may be '-' for stdin
- Also checked SunOS manual page, and it is consistent with BSD [2]
- Update usage string and description in POD
- While here, add explicit close() call in do_file() so we can exit with failure code if close() fails
- Delete comment at top of file which duplicates what is written in POD
- Bump version
- https://pubs.opengroup.org/onlinepubs/009695399/utilities/nl.html
- https://shrubbery.net/solaris9ab/SUNWaman/hman1/nl.1.html
* Standard nl is not required to support multiple input files [1] * Follow BSD versions of nl and support only one input file, which may be '-' for stdin * Also checked SunOS manual page, and it is consistent with BSD [2] * Update usage string and description in POD * While here, add explicit close() call in do_file() so we can exit with failure code if close() fails * Delete comment at top of file which duplicates what is written in POD * Bump version 1. https://pubs.opengroup.org/onlinepubs/009695399/utilities/nl.html 2. https://shrubbery.net/solaris9ab/SUNWaman/hman1/nl.1.html
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Mar 2, 2024
briandfoy
added
Status: accepted
|
changes: specify exactly one file on the command line |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.