shar: error detected for no files processed #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Feb 29, 2024
mknos
commented
- Print usage and exit if no file arguments are given (in docs, at least one file argument is required and standard input is not used)
- Remove variable $dirty for keeping track of whether header was printed; just print it once before loop
- Introduce variable $done to count how many files were processed
- Checking $dirty at end of loop was incorrect; this resulted in printing an error on success and exiting with error code
- test1: "perl shar" --> no args, usage
- test2: "perl shar no-such-file" --> print message "no files were processed"
- test3: "perl shar tar" --> archive one file 'tar' successfully
* Print usage and exit if no file arguments are given (in docs, at least one file argument is required and standard input is not used) * Remove variable $dirty for keeping track of whether header was printed; just print it once before loop * Introduce variable $done to count how many files were processed * Checking $dirty at end of loop was incorrect; this resulted in printing an error on success and exiting with error code * test1: "perl shar" --> no args, usage * test2: "perl shar no-such-file" --> print message "no files were processed" * test3: "perl shar tar" --> archive one file 'tar' successfully
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Feb 29, 2024
briandfoy
added
Status: accepted
|
changes: handle missing or unreadable files |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.