expand: regex too greedy #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Feb 23, 2024
mknos
commented
- This version of expand follows standard and does not treat '-' as stdin [1]
- Unfortunately the regex for the -1,2,3 tab-stop form was matching incorrectly because:
- zero characters after '-' were allowed (valid usage requires at least 1 digit after dash)
- '-' was allowed to appear after the first character
- With this patch, invalid usage "perl expand - -" fails on the first instance of '-'
- https://pubs.opengroup.org/onlinepubs/007904975/utilities/expand.html
* This version of expand follows standard and does not treat '-' as stdin [1] * Unfortunately the regex for the -1,2,3 tab-stop form was matching incorrectly because: 1) zero characters after '-' were allowed (valid usage requires at least 1 digit after dash) 2) '-' was allowed to appear after the first character * With this patch, invalid usage "perl expand - -" fails on the first instance of '-' 1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/expand.html
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Feb 29, 2024
briandfoy
added
Status: accepted
|
changes: fix command line processing regex |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.