bc: array assignment incorrectly prints #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Feb 12, 2024
mknos
commented
- In exec_stmt(), instruction 'p' takes an array name and index number, then pushes the array element onto the stack (implicit print)
- The default value for array elements is 0
- The instruction '=P' assignd a value from the stack into an array element
- Make the code for 'p' simpler by appending '[]' to $name, as done for '=P' instruction
- For instruction '=P' the value being assigned to array should not be printed (this is controlled by $return variable)
- For input "a[9] = 123; a[9];" the value of 123 should be printed once, for the 2nd statement
- Tested this input against GNU and OpenBSD versions
* In exec_stmt(), instruction 'p' takes an array name and index number, then pushes the array element onto the stack (implicit print) * The default value for array elements is 0 * The instruction '=P' assignd a value from the stack into an array element * Make the code for 'p' simpler by appending '[]' to $name, as done for '=P' instruction * For instruction '=P' the value being assigned to array should not be printed (this is controlled by $return variable) * For input "a[9] = 123; a[9];" the value of 123 should be printed once, for the 2nd statement * Tested this input against GNU and OpenBSD versions
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Feb 12, 2024
briandfoy
added
Status: accepted
|
changes: don't print value after array element assignment |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.