cmp: check length off-by-one #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Feb 10, 2024
mknos
commented
- $checklength is the maximum offset in buffer to check which byte(s) in the 2 buffers are not equal
- The subsequent loop is from 0 to $checklength, so avoid potentially accessing $bytes1[$chunk_size]
- If $read_in1 and $read_in2 are equal to $chunk_size, the value of $checklength is not decremented
- Calculate minimum of $read_in1 and $read_in2 (these will never exceed $chunk_size), then decrement by 1
* $checklength is the maximum offset in buffer to check which byte(s) in the 2 buffers are not equal * The subsequent loop is from 0 to $checklength, so avoid potentially accessing $bytes1[$chunk_size] * If $read_in1 and $read_in2 are equal to $chunk_size, the value of $checklength is not decremented * Calculate minimum of $read_in1 and $read_in2 (these will never exceed $chunk_size), then decrement by 1
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Feb 11, 2024
briandfoy
added
Status: accepted
|
changes: fix off-by-one error |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.