Skip to content

arch: forbid command arguments #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2024
Merged

arch: forbid command arguments #438

merged 1 commit into from
Feb 2, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 2, 2024

  • Make arch command more compatible: no arguments are allowed
  • Incorrect options were ignored but should raise an error
  • GNU and OpenBSD versions raise an error for these 2 cases; OpenBSD prints usage string
  • test1: "perl arch -k arch" --> valid option, invalid argument
  • test2: "perl arch -x" --> invalid option

@mknos
arch: forbid command arguments
50e15d2 
* Make arch command more compatible: no arguments are allowed
* Incorrect options were ignored but should raise an error
* GNU and OpenBSD versions raise an error for these 2 cases; OpenBSD prints usage string
* test1: "perl arch -k arch" --> valid option, invalid argument
* test2: "perl arch -x" --> invalid option
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: arch The arch program labels Feb 2, 2024
@briandfoy briandfoy merged commit 15f7f71 into briandfoy:master Feb 2, 2024
@briandfoy briandfoy self-assigned this Feb 2, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 2, 2024
@briandfoy
Copy link
Owner

changes: reject all arguments

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: arch The arch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy