Skip to content

cat: explicitly close files #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2024
Merged

cat: explicitly close files #423

merged 1 commit into from
Jan 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 28, 2024

  • Guarantee that if close() failed for file1 that we print a warning for file1 before proceeding to process file2, then eventually exit with error code
  • To preserve "cat - -", make sure *STDIN is not closed (on my linux system I type ctrl-d twice to terminate do_file() with EOF)

@mknos
cat: explicitly close files
df41291 
* Guarantee that if close() failed for file1 that we print a warning for file1 before proceeding to process file2, then eventually exit with error code
* To preserve "cat - -", make sure *STDIN is not closed (on my linux system I type ctrl-d twice to terminate do_file() with EOF)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cat The cat program labels Jan 28, 2024
@briandfoy briandfoy self-assigned this Jan 28, 2024
@briandfoy briandfoy merged commit ae0c5f6 into briandfoy:master Jan 28, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 28, 2024
@briandfoy
Copy link
Owner

changes: explicitly close files

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cat The cat program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy