hangman versus small file #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jan 25, 2024
mknos
commented
- When testing hangman with a small word list the game would terminate before it even started
- get_a_word() assumed that the wordlist file had 9151 words in it
- This would be a problem for larger word lists too; the list is effectively truncated
- Scale random index ($val) based on the number of lines in word list (with penalty of reading list twice)
- Filehandle FILE used in close() was incorrect
- Raise error if close() failed
- Test1: wordlist.txt with only 2 words
- Test2: wordlist.txt from dict file on my linux system (101,924 words)
* When testing hangman with a small word list the game would terminate before it even started * get_a_word() assumed that the wordlist file had 9151 words in it * This would be a problem for larger word lists too; the list is effectively truncated * Scale random index ($val) based on the number of lines in word list (with penalty of reading list twice) * Filehandle FILE used in close() was incorrect * Raise error if close() failed * Test1: wordlist.txt with only 2 words * Test2: wordlist.txt from dict file on my linux system (101,924 words)
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Jan 25, 2024
briandfoy
added
Status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.