Skip to content

ed: simplify relative line calculation #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

ed: simplify relative line calculation #413

merged 1 commit into from
Jan 23, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 23, 2024

  • Based on prior regex, "+-" and "-+" are invalid relative addresses; GNU ed accepts "+-" but this version treats it as "extra arguments" error
  • "++n" is numbered print, 2 lines ahead of currentLine
  • "--n" is numbered print, 2 lines behind currentLine
  • Only one of $pluses or $minuses will be set at this time
  • Writing the logic in this way will make it easier to support "--++" in future for GNU compat

@mknos
ed: simplify relative line calculation
c92022a 
* Based on prior regex, "+-" and "-+" are invalid relative addresses; GNU ed accepts this but this version treats it as "extra arguments" error
* "++n" is numbered print, 2 lines ahead of currentLine
* "--n" is numbered print, 2 lines behind currentLine
* Only one of $pluses or $minuses will be set at this time
* Writing the logic in this way will make it easier to support "--++" in future for GNU compat
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 23, 2024
briandfoy
briandfoy approved these changes Jan 23, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's much easier to figure out.

@briandfoy briandfoy self-assigned this Jan 23, 2024
@briandfoy briandfoy merged commit e27836a into briandfoy:master Jan 23, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy