Skip to content

Sidebar Search Filter #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Conversation

denisahearn
Copy link
Contributor

  • Adds a Search Filter input at the top of the sidebar. As the user types in the input, the contents of the sidebar are automatically filtered to show only the items that contain the search text.
  • Debounces the key strokes/input to avoid running the filtering logic excessively

Screenshot 2024-12-19 at 1 14 25 PM

Demo: https://app.screencast.com/6cWUizeYtvRBX

@brettchalupa
Copy link
Owner

@denisahearn thank you so much for this PR! It's looking great from first-glance. I am hoping to be able to review it more in depth this week. I appreciate your patience and contribution!

@denisahearn
Copy link
Contributor Author

@brettchalupa Gentle nudge - Any chance you'll be able to look at this PR sometime soon? I'm not using this change in our Rails app yet, but if you think you won't be able to get to this for a while, I might consider puling in the changes from our fork until you get a chance to look at this PR.

No pressure, I get it.

@brettchalupa
Copy link
Owner

@denisahearn thanks for the nudge! I'll work on reviewing it today. I've got a new baby and a new job, so time is just flying by at unprecedented speeds right now. 😅

Copy link
Owner

@brettchalupa brettchalupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @denisahearn, thank you so much! It's working really well for me on desktop and mobile. Code looks good to me. 👏 🚢

@brettchalupa
Copy link
Owner

I'm going to merge this and work on getting a new version released today.

@brettchalupa brettchalupa merged commit 482f9cd into brettchalupa:main Feb 9, 2025
4 checks passed
@brettchalupa brettchalupa mentioned this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants