update glob #434
Closed
update glob #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
commented
Nov 18, 2025
package.json
Outdated
| "git-describe": "4.1.1", | ||
| "git-rev": "0.2.1", | ||
| "glob": "8.1.0", | ||
| "glob": "11.1.0", |
Member
Author
There was a problem hiding this comment.
this might break some stuff, not sure how to test it
Collaborator
There was a problem hiding this comment.
Looks like there is at least one breakage in CI (across all workflows):
Collaborator
|
The issue is here |
Collaborator
|
Both current and latest versions of testem |
Member
Author
|
@yshym that's unfortunate. i'm guessing we can't migrate to something that doesn't rely on a vulnerable version of glob? in any case i think GHSA-5j98-mcp5-4vw2 only affects the glob CLI which we aren't using directly in this repo. so probably ok to ignore? |
Collaborator
|
Yes, I think let's ignore for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/brave/web-discovery-project/security/dependabot/57