jsonSerialize() returns empty array for Braintree\Result\Successful

[jmauzyk]

Currently, when calling jsonSerialize() on Braintree\Result\Successful, it returns an empty array. This is because the method simply returns the $_attributes property, which doesn't contain any data for a Successful object.

This wasn't an issue for us previously, since our application's JSON helper would manually generate an array when serializing Successful results for JSON encoding. However, since the implementation of \JsonSerializable in v6.32.0, our application now uses a different code pathway, resulting in an empty array being returned where we need to receive a serialized representation of the Successful result.

Could you clarify whether returning an empty array from Braintree\Result\Successful::jsonSerialize() is the intended behavior? This would help us determine whether to implement our own serialization or if there are plans to add serialization support to the Successful result class.

[nalshapub]

Let us review and get back to you. Thanks for raising the issue.

[david-fairbanks42]

This is biting me now too. Had to roll back to 6.31.0.

[nalshapub]

We are actively looking at this one, we'll have an update soon.

[david-fairbanks42]

I have tried the following on the transaction sale response (Successful) object and they all return an empty value on 6.32.0.

$response->toArray();
json_decode(json_encode($response), true);
$response->jsonSerialize();

To get 6.32.0 to work, this is the work around I'm now using.

$response = $bt->transaction()->sale($sale);
// ... handling for unsuccessful sale
$resp = [
    'success' => $response->success,
    'transaction' => $response->transaction->toArray(),
];