This repository was archived by the owner on Jan 19, 2019. It is now read-only.
New: Add no-parameter-properties #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Aug 19, 2017
| } | ||
|
|
||
| class Foo { | ||
| constructor(public readonly name: string) {} |
There was a problem hiding this comment.
Should this be allowed if the options are { "allows": ["public", "readonly"] }?
There was a problem hiding this comment.
I added accesibility + readonly modifiers as separate options to avoid scenarios like 'I want to allow protected, public and public readonly, but no protected readonly'.
Does that make sense? it did when I was writing it, but I'm open to suggestions...
j-f1
reviewed
Aug 19, 2017
README.md
Outdated
| @@ -62,6 +62,7 @@ Then configure the rules you want to use under the rules section. | |||
| * [`typescript/member-ordering`](./docs/rules/member-ordering.md) — enforces a standard member declaration order. (`member-ordering` from TSLint) | |||
| * [`typescript/no-unused-vars`](./docs/rules/no-unused-vars.md) — prevents TypeScript-specific constructs from being erroneously flagged as unused | |||
| * [`typescript/adjacent-overload-signatures`](./docs/rules/adjacent-overload-signatures.md) — enforces member overloads to be consecutive. | |||
| * [`typescript/no-parameter-properties`](./docs/rules/no-parameter-properties.md) - disallows parameter properties in class constructors. | |||
There was a problem hiding this comment.
Can you reference the name of the TSLint rule here?
|
I resolved the conflicts on here too @weirdpattern, so make sure you pull before continuing to work on it 👍 |
weirdpattern
force-pushed
the
no-parameter-properties
branch
from
e4b6fea to
b4e069c
Compare
|
I did the same as you did, used github to resolve the conflict... |
j-f1
approved these changes
Aug 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes
New rule no-parameter-properties
Corresponding test
Corresponding documentation
Update to README.md to include the new rule
Related to #5 (TSLint compatibility)