Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

New: class-name-casing rule (class-name from TSLint) #44

Merged
merged 3 commits into from
Aug 19, 2017

Conversation

j-f1
Copy link
Collaborator

@j-f1 j-f1 commented Aug 13, 2017

Implements #5 (comment).

Copy link
Collaborator

@weirdpattern weirdpattern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the title to include the type of work performed?
You can follow eslint PR guidelines

@weirdpattern
Copy link
Collaborator

Awesome, code LGTM
Please prefix the title with 'New:' so the PR can be easily identified as a rule addition.

@j-f1 j-f1 changed the title class-name-casing (class-name from TSLint) New: class-name-casing rule (class-name from TSLint) Aug 13, 2017
@dannyfritz dannyfritz mentioned this pull request Aug 13, 2017
31 tasks
@corbinu
Copy link
Contributor

corbinu commented Aug 13, 2017

LGTM

@JamesHenry
Copy link
Collaborator

Thanks! The older README.md cleanup PR that went in means this just needs to be rebased before going in

@j-f1
Copy link
Collaborator Author

j-f1 commented Aug 18, 2017

@JamesHenry Done!

@JamesHenry JamesHenry merged commit 26f2609 into bradzacher:master Aug 19, 2017
@j-f1 j-f1 deleted the class-name branch August 19, 2017 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants