Move NVIDIA kmods to drivers.target - #321
Merged
Merged
Conversation
added 4 commits
November 15, 2025 00:06
The drivers.target is a more correct target for loading the NVIDIA drivers. This shifts the Required target to drivers.target from preconfigured.target. Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
The drivers.target is a more correct target for loading the NVIDIA drivers. This shifts the Required target to drivers.target from preconfigured.target. Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
The drivers.target is a more correct target for loading the NVIDIA drivers. This shifts the Required target to drivers.target from preconfigured.target. Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
The drivers.target is a more correct target for loading the NVIDIA drivers. This shifts the Required target to drivers.target from preconfigured.target. Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
bcressey
approved these changes
Nov 17, 2025
bcressey
left a comment
bcressey
left a comment
Contributor
There was a problem hiding this comment.
This side of the change seems fine. However, we're missing a dependency to cause drivers.target to be reached before we'd initiate kernel lockdown.
I'd recommend adding Before=settings-applier.service to drivers.target, over in "release".
arnaldo2792
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to : bottlerocket-os/bottlerocket#4218 (comment)
Description of changes:
This change moves the NVIDIA kmod package to load before
drivers.targetinstead ofpreconfigured.target. This allows us to separate the state of loading all kernel modules from the rest of configuration.Testing done:
Built NVIDIA variants for both arches and k8s 1.33 and ECS 2. Validated that the drivers come up for all 3 versions of the driver based upon hardware and fail as expected if no NVIDIA devices are present:
Failure on m6i.large:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.