build GRUB with optimizations and don't ship tools or modules - #163
Merged
Conversation
added 2 commits
May 28, 2025 22:46
The tools and modules are only expected to be used at build time, to create the final bootloader images. Signed-off-by: Ben Cressey <bcressey@amazon.com>
`-Os` is the default if TARGET_CFLAGS is not set in the environment. Add it to avoid building without any optimizations at all. Signed-off-by: Ben Cressey <bcressey@amazon.com>
arnaldo2792
approved these changes
May 28, 2025
rpkelly
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #161, fixes #162
Description of changes:
Drop the tools and modules subpackages, as they're not used and shouldn't be used downstream.
Build GRUB with
-Os, as upstream intends and like other distros do.Testing done:
Verified that both EC2 instances and VMware guests could boot in both EFI and BIOS modes.
The GRUB images are around 30% smaller.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.