Add hostPrefix support to RPC v2 CBOR serializer #3592
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3592 +/- ##
===========================================
- Coverage 93.17% 92.71% -0.47%
===========================================
Files 68 68
Lines 15411 15560 +149
===========================================
+ Hits 14359 14426 +67
- Misses 1052 1134 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
So I'm alright without a changelog since no services that are released today use CBOR in botocore, but I'd like to update the description a bit. Can we clarify that this is bringing it inline with every other protocol, not just JSON, or remove that sentence?
tests/unit/test_serialize.py
Outdated
|
|
||
| self.assertNotIn('host_prefix', serialized) | ||
|
|
||
| def test_no_host_prefix_when_params_invalid(self): |
There was a problem hiding this comment.
This test isn't actually testing anything about host prefix, right? We shouldn't include this unless it's testing related behavior.
There was a problem hiding this comment.
Yeah, the test doesn’t reach the change in serialize.py, but it validates that ParamValidationError is raised when a parameter with an invalid key name (that doesn’t exist in the shape : ’Foo-Non-existant’) is used.
* release-1.42.2: Bumping version to 1.42.2 Update to latest models Add hostPrefix support to RPC v2 CBOR serializer (#3592)
4 participants
Description of changes:
This change adds hostPrefix support to the RPC v2 CBOR serializer by including the host prefix in the serialized request.
Testing
Verified that all tests pass successfully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.